-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make environments opcodes use varying operands #3340
Conversation
40aa140
to
6149ec2
Compare
b787469
to
885cd26
Compare
6149ec2
to
265a4c9
Compare
885cd26
to
175c434
Compare
Test262 conformance changes
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3340 +/- ##
==========================================
- Coverage 49.51% 49.49% -0.03%
==========================================
Files 446 446
Lines 43777 43767 -10
==========================================
- Hits 21678 21663 -15
- Misses 22099 22104 +5
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change!
Depends on #3332
Makes environment push opcodes that take index use varying operands, this required a bit of a refactor so we store environments pushed starting at zero, not in reversed order.