-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix super()
construction with default parameters
#3339
Conversation
Test262 conformance changes
Broken tests (2):
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3339 +/- ##
==========================================
- Coverage 49.45% 49.42% -0.03%
==========================================
Files 446 446
Lines 43948 43914 -34
==========================================
- Hits 21733 21704 -29
+ Misses 22215 22210 -5
☔ View full report in Codecov by Sentry. |
- Remove unused `PushDeclarativeEnvironment` opcode
7481491
to
e21a28c
Compare
super()
construction with default parameters
Yes that is correct. I have a fix for that, but it depends on #3332 and coincidentally this MR too :) |
Fixes the class
super()
construction error thrown when the derived class has default parameters.For example (used as a test case):
This PR breaks two test262 tests:
But I think this is due to the following steps that we haven't implement in
FunctionDeclarationInstantiation
: