-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI testing #3333
Merged
Merged
Improve CI testing #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3333 +/- ##
==========================================
- Coverage 49.42% 49.41% -0.02%
==========================================
Files 445 445
Lines 43891 43898 +7
==========================================
- Hits 21691 21690 -1
- Misses 22200 22208 +8
☔ View full report in Codecov by Sentry. |
nekevss
reviewed
Oct 2, 2023
nekevss
approved these changes
Oct 2, 2023
HalidOdat
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some small improvements in our CI to ensure we're testing everything.
One unfortunate thing I realized is that
cargo clippy -- -D warnings
apparently doesn't work with our current setup, somehow. I think clippy is interpreting our crate global warns as overriding the command argument-D warnings
, but it seems that this was fixed on rust-lang/rust-clippy#5749. Maybe the bug reappeared for workspaces?Anyways, I confirmed that the warnings do error with the new
[lints]
section forCargo.toml
, so this should be fixed when Rustc 1.74 releases. I'll probably open a new draft PR for that, just to have a reminder to merge the changes at that time. In the meantime, let's just ensure we check the actions for any warnings before merging any PR.