Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing class name binding #3328

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Add missing class name binding #3328

merged 1 commit into from
Oct 1, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented Sep 30, 2023

This Pull Request changes the following:

  • Add missing class name binding

@raskad raskad added bug Something isn't working execution Issues or PRs related to code execution labels Sep 30, 2023
@raskad raskad added this to the v0.18.0 milestone Sep 30, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,197 75,201 +4
Ignored 19,482 19,482 0
Failed 895 891 -4
Panics 0 0 0
Conformance 78.68% 78.68% +0.00%
Fixed tests (4):
test/language/statements/class/scope-name-lex-open-heritage.js [strict mode] (previously Failed)
test/language/statements/class/scope-name-lex-open-heritage.js (previously Failed)
test/language/expressions/class/scope-name-lex-open-heritage.js [strict mode] (previously Failed)
test/language/expressions/class/scope-name-lex-open-heritage.js (previously Failed)

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (332fd65) 49.36% compared to head (6027a0d) 49.34%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3328      +/-   ##
==========================================
- Coverage   49.36%   49.34%   -0.03%     
==========================================
  Files         444      445       +1     
  Lines       43843    43892      +49     
==========================================
+ Hits        21643    21657      +14     
- Misses      22200    22235      +35     
Files Coverage Δ
boa_engine/src/bytecompiler/class.rs 14.70% <100.00%> (ø)

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raskad raskad requested a review from a team September 30, 2023 19:16
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jedel1043 jedel1043 added this pull request to the merge queue Oct 1, 2023
Merged via the queue into main with commit 8fd4744 Oct 1, 2023
@HalidOdat HalidOdat deleted the fix-class-lex-name branch October 1, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants