Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icu_properties default features to true #3326

Merged
merged 3 commits into from
Sep 30, 2023
Merged

icu_properties default features to true #3326

merged 3 commits into from
Sep 30, 2023

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Sep 30, 2023

Currently there are errors when trying to run compile or run tests in boa_parser without the compiled_data feature. So just enabling the feature flag.

@nekevss nekevss changed the title Default features to true icu_properties default features to true Sep 30, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,193 75,193 0
Ignored 19,482 19,482 0
Failed 899 899 0
Panics 0 0 0
Conformance 78.68% 78.68% 0.00%

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b80409d) 49.72% compared to head (9603b89) 49.72%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3326      +/-   ##
==========================================
- Coverage   49.72%   49.72%   -0.01%     
==========================================
  Files         443      443              
  Lines       43378    43378              
==========================================
- Hits        21570    21569       -1     
- Misses      21808    21809       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss requested a review from a team September 30, 2023 01:48
@nekevss nekevss added the dependencies Pull requests that update a dependency file label Sep 30, 2023
@jedel1043
Copy link
Member

Can you add a CI action to check for this?

@nekevss nekevss requested a review from a team September 30, 2023 03:51
@raskad raskad added this pull request to the merge queue Sep 30, 2023
Merged via the queue into main with commit 7eadcbd Sep 30, 2023
10 checks passed
@raskad raskad deleted the icu-properties-feature branch September 30, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants