Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anonymous function name in cover assignment #3325

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented Sep 29, 2023

This Pull Request changes the following:

  • Fix anonymous function name in cover assignment

@raskad raskad added bug Something isn't working parser Issues surrounding the parser labels Sep 29, 2023
@raskad raskad added this to the v0.18.0 milestone Sep 29, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,193 75,195 +2
Ignored 19,482 19,482 0
Failed 899 897 -2
Panics 0 0 0
Conformance 78.68% 78.68% +0.00%
Fixed tests (2):
test/language/expressions/assignment/fn-name-lhs-cover.js [strict mode] (previously Failed)
test/language/expressions/assignment/fn-name-lhs-cover.js (previously Failed)

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (70ee050) 49.72% compared to head (b1eff9d) 49.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3325      +/-   ##
==========================================
- Coverage   49.72%   49.72%   -0.01%     
==========================================
  Files         443      443              
  Lines       43378    43378              
==========================================
- Hits        21570    21569       -1     
- Misses      21808    21809       +1     
Files Coverage Δ
boa_parser/src/parser/expression/assignment/mod.rs 77.87% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raskad raskad requested a review from a team September 30, 2023 00:19
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch! :)

@HalidOdat HalidOdat requested a review from a team September 30, 2023 11:23
@jedel1043 jedel1043 added this pull request to the merge queue Sep 30, 2023
Merged via the queue into main with commit ebb40ae Sep 30, 2023
10 checks passed
@raskad raskad deleted the fix-anonymus-function-name-infer branch September 30, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants