Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce experimental features #3318

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Introduce experimental features #3318

merged 2 commits into from
Sep 28, 2023

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Sep 27, 2023

Related to #3277

Since the Temporal PR is as big as it gets, I thought it would be good to introduce the experimental flag in a separate PR, which should reduce the review work a bit.
This also introduces the Promise.withResolvers method, just so that there's at least some feature using the flag.

@jedel1043 jedel1043 added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics API labels Sep 27, 2023
@jedel1043 jedel1043 added this to the v0.18.0 milestone Sep 27, 2023
@jedel1043 jedel1043 requested a review from a team September 27, 2023 20:15
@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,181 75,193 +12
Ignored 19,494 19,482 -12
Failed 899 899 0
Panics 0 0 0
Conformance 78.66% 78.68% +0.01%
Fixed tests (12):
test/built-ins/Promise/withResolvers/ctx-non-object.js [strict mode] (previously Ignored)
test/built-ins/Promise/withResolvers/ctx-non-object.js (previously Ignored)
test/built-ins/Promise/withResolvers/promise.js [strict mode] (previously Ignored)
test/built-ins/Promise/withResolvers/promise.js (previously Ignored)
test/built-ins/Promise/withResolvers/result.js [strict mode] (previously Ignored)
test/built-ins/Promise/withResolvers/result.js (previously Ignored)
test/built-ins/Promise/withResolvers/ctx-non-ctor.js [strict mode] (previously Ignored)
test/built-ins/Promise/withResolvers/ctx-non-ctor.js (previously Ignored)
test/built-ins/Promise/withResolvers/ctx-ctor.js [strict mode] (previously Ignored)
test/built-ins/Promise/withResolvers/ctx-ctor.js (previously Ignored)
test/built-ins/Promise/withResolvers/resolvers.js [strict mode] (previously Ignored)
test/built-ins/Promise/withResolvers/resolvers.js (previously Ignored)

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (ae41479) 49.69% compared to head (89c1695) 49.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3318      +/-   ##
==========================================
- Coverage   49.69%   49.69%   -0.01%     
==========================================
  Files         443      443              
  Lines       43141    43167      +26     
==========================================
+ Hits        21439    21451      +12     
- Misses      21702    21716      +14     
Files Coverage Δ
boa_engine/src/vm/code_block.rs 52.45% <ø> (ø)
boa_engine/src/context/intrinsics.rs 97.57% <86.66%> (-0.56%) ⬇️
boa_engine/src/builtins/promise/mod.rs 29.63% <23.52%> (-0.44%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Definitely like the idea of introducing the experimental flag separate from the Temporal PR.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@jedel1043 jedel1043 added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 615ae4e Sep 28, 2023
10 checks passed
@raskad raskad deleted the experimental-features branch September 30, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants