-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce experimental features #3318
Conversation
Test262 conformance changes
Fixed tests (12):
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3318 +/- ##
==========================================
- Coverage 49.69% 49.69% -0.01%
==========================================
Files 443 443
Lines 43141 43167 +26
==========================================
+ Hits 21439 21451 +12
- Misses 21702 21716 +14
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Definitely like the idea of introducing the experimental flag separate from the Temporal PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
Related to #3277
Since the Temporal PR is as big as it gets, I thought it would be good to introduce the experimental flag in a separate PR, which should reduce the review work a bit.
This also introduces the
Promise.withResolvers
method, just so that there's at least some feature using the flag.