-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a Class
map
#3315
Introduce a Class
map
#3315
Conversation
Test262 conformance changes
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3315 +/- ##
==========================================
- Coverage 49.72% 49.68% -0.04%
==========================================
Files 443 443
Lines 43378 43410 +32
==========================================
Hits 21570 21570
- Misses 21808 21840 +32
☔ View full report in Codecov by Sentry. |
d5234a1
to
c38c2db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just some comments, they don't block merging though :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me! :)
Related to #3314.
This change improves the ergonomics of the
Class
API by adding a class map that can be used to fetch the constructor and prototype of a registered class. This also slightly improves its API by implementing some missing features like using symbols as method names.