-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Intl.PluralRules
#3298
Conversation
Test262 conformance changes
Fixed tests (72):
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3298 +/- ##
==========================================
- Coverage 50.21% 49.80% -0.41%
==========================================
Files 436 441 +5
Lines 42691 43078 +387
==========================================
+ Hits 21438 21456 +18
- Misses 21253 21622 +369
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this is looking good to me, but there's some observations I had re: ecma402
and temporal
/intl
shared concepts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me 😄 nice work! I had one nit, but I'd be fine with merging either way.
48b7d04
to
bb29381
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Looks great to me! :)
This Pull Request implements the
Intl.PluralRules
service. It also implements some number formatting tools that will be useful when we eventually implementIntl.NumberFormat
.Intl.PluralRules.prototype.selectRange
needs support from ICU4X first, but I'm in charge of it and I'll try to finish it soon™. You can track its progress on unicode-org/icu4x#3012.