Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ordinary VM calling #3295

Merged
merged 5 commits into from
Oct 19, 2023

Apply review

4f41c38
Select commit
Loading
Failed to load commit list.
Merged

Refactor ordinary VM calling #3295

Apply review
4f41c38
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 19, 2023 in 0s

45.78% (+0.06%) compared to a9e3849

View this Pull Request on Codecov

45.78% (+0.06%) compared to a9e3849

Details

Codecov Report

Attention: 170 lines in your changes are missing coverage. Please review.

Comparison is base (a9e3849) 45.71% compared to head (4f41c38) 45.78%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3295      +/-   ##
==========================================
+ Coverage   45.71%   45.78%   +0.06%     
==========================================
  Files         482      483       +1     
  Lines       49182    49349     +167     
==========================================
+ Hits        22486    22595     +109     
- Misses      26696    26754      +58     
Files Coverage Δ
boa_engine/src/builtins/eval/mod.rs 66.00% <100.00%> (+1.78%) ⬆️
boa_engine/src/builtins/generator/mod.rs 36.02% <100.00%> (-0.93%) ⬇️
boa_engine/src/builtins/json/mod.rs 85.13% <100.00%> (+0.22%) ⬆️
boa_engine/src/bytecompiler/declarations.rs 51.05% <100.00%> (-0.12%) ⬇️
boa_engine/src/bytecompiler/expression/mod.rs 58.41% <100.00%> (+0.19%) ⬆️
boa_engine/src/bytecompiler/mod.rs 66.92% <ø> (ø)
boa_engine/src/object/internal_methods/mod.rs 87.44% <100.00%> (+2.82%) ⬆️
boa_engine/src/object/operations.rs 52.36% <100.00%> (+3.96%) ⬆️
boa_engine/src/script.rs 82.53% <100.00%> (+1.50%) ⬆️
boa_engine/src/vm/opcode/await/mod.rs 73.75% <100.00%> (+1.38%) ⬆️
... and 22 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.