Update conformance page to ES14 #3274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
enhancement
HalidOdat
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Should this be commited/changed?
There was a problem hiding this comment.
We technically don't need to commit it to pass CI, but I think we should, since it'll return wrong results for users who want to compare with main if we don't.
nekevss
approved these changes
Sep 13, 2023
jedel1043
force-pushed
the
es14-page-update
branch
from
ad4e0e7 to
eb635c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3273.
This PR adds a new
ES14option to our version selector.Had to also update the versions of the ESNext tests from 14 to 255, since ESNext is represented by
u8::MAX. This is the cause of the big diffs onmain/latest.jsonandv0.17/latest.json.Since this'll probably break CI until #3273 is merged, we should wait until that PR is approved so that we can merge both consecutively.