Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varying length instruction operands #3253

Merged
merged 3 commits into from
Sep 30, 2023

Apply review

1fba8c2
Select commit
Loading
Failed to load commit list.
Merged

Varying length instruction operands #3253

Apply review
1fba8c2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 30, 2023 in 1s

49.36% (-0.37%) compared to 70ee050

View this Pull Request on Codecov

49.36% (-0.37%) compared to 70ee050

Details

Codecov Report

Attention: 660 lines in your changes are missing coverage. Please review.

Comparison is base (70ee050) 49.72% compared to head (1fba8c2) 49.36%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3253      +/-   ##
==========================================
- Coverage   49.72%   49.36%   -0.37%     
==========================================
  Files         443      444       +1     
  Lines       43378    43843     +465     
==========================================
+ Hits        21570    21642      +72     
- Misses      21808    22201     +393     
Files Coverage Δ
boa_engine/src/bytecompiler/expression/unary.rs 100.00% <100.00%> (ø)
boa_engine/src/bytecompiler/utils.rs 78.57% <100.00%> (ø)
boa_engine/src/vm/opcode/nop/mod.rs 0.00% <ø> (ø)
boa_engine/src/bytecompiler/expression/binary.rs 74.62% <0.00%> (ø)
boa_engine/src/bytecompiler/statement/loop.rs 76.26% <75.00%> (ø)
boa_engine/src/module/source.rs 0.00% <0.00%> (ø)
boa_engine/src/bytecompiler/expression/mod.rs 56.58% <80.00%> (-0.22%) ⬇️
boa_engine/src/vm/opcode/modifier.rs 50.00% <50.00%> (ø)
boa_engine/src/vm/opcode/push/literal.rs 76.92% <75.00%> (-23.08%) ⬇️
...gine/src/bytecompiler/expression/object_literal.rs 54.16% <55.55%> (ø)
... and 34 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.