Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization fast local variables #3194

Closed
wants to merge 3 commits into from

Don't create parameter expressions environment if not used

d53a0c4
Select commit
Loading
Failed to load commit list.
Closed

Optimization fast local variables #3194

Don't create parameter expressions environment if not used
d53a0c4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 4, 2023 in 0s

49.60% (+0.06%) compared to a51581b

View this Pull Request on Codecov

49.60% (+0.06%) compared to a51581b

Details

Codecov Report

Attention: 171 lines in your changes are missing coverage. Please review.

Comparison is base (a51581b) 49.53% compared to head (d53a0c4) 49.60%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3194      +/-   ##
==========================================
+ Coverage   49.53%   49.60%   +0.06%     
==========================================
  Files         446      446              
  Lines       43722    44070     +348     
==========================================
+ Hits        21659    21861     +202     
- Misses      22063    22209     +146     
Files Coverage Δ
boa_engine/src/bytecompiler/expression/assign.rs 42.13% <100.00%> (+3.88%) ⬆️
...gine/src/bytecompiler/expression/object_literal.rs 54.16% <100.00%> (ø)
boa_engine/src/bytecompiler/expression/unary.rs 100.00% <100.00%> (ø)
boa_engine/src/bytecompiler/function.rs 97.40% <100.00%> (-2.60%) ⬇️
boa_engine/src/bytecompiler/jump_control.rs 94.47% <100.00%> (+0.05%) ⬆️
boa_engine/src/bytecompiler/statement/block.rs 100.00% <100.00%> (ø)
boa_engine/src/bytecompiler/statement/loop.rs 77.23% <100.00%> (+2.13%) ⬆️
boa_engine/src/bytecompiler/statement/mod.rs 91.17% <100.00%> (ø)
boa_engine/src/bytecompiler/statement/switch.rs 100.00% <100.00%> (ø)
boa_engine/src/bytecompiler/statement/try.rs 91.11% <100.00%> (+0.20%) ⬆️
... and 17 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.