-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include bson library and use its BinaryParser #21
Conversation
you need either include bson in dependencies of package.json or use a full path to bson in mongoose/node_modules/mongodb/node_modules/bson/lib |
Could this be pull request be accepted and a new version pushed of the module pushed to NPM (or one of the other pull requests that resolves the BinaryParser issue)? Thanks! : ) |
The author seems to have a ton of other things going on, including several other highly-used modules, so it's probably going to be a while before this gets fixed :(. In the meantime, you can fork and fix, or use one of the pull requests in your package.json. For example, this works: |
Wow, I didn't know you could list a git repo as a dependency -- that's What I had been doing as a temporary solution was to clone that pull Thanks very much for the info! : ) |
You're quite welcome. It's a handy little trick. I believe you can add a specific commit to the path too, but I have yet to have that work correctly. IIRC, the syntax is git://path.to.repo#branch@sha, or something like git://github.com/w33ble/mongoose-types.git#bson-patch@fb0de2f. And of course, if this is something you're relying on, it's probably best to fork and reference your own repo. That way you have complete control over changes. Handy in case I push a change that breaks your code ;) |
Is there any updates? Is Mongoose-types active now? |
Seems like this repo is inactive. You may find some forks that are still active or take a look at https://github.com/tblobaum/mongoose-troop#timestamp |
Thanks @jackdbernier, that module looks pretty nice! |
The mongo package no longer seems to include bson's BinaryParser, so the reference doesn't work anymore. Instead of relying on mongo, I thought it appropriate to include bson in this module instead.
Related to pull request #17, just a different way to fix the problem