This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Feature/add cacheSize config, fix tomcat log cache warning. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingxiuyi
changed the title
|
only support tomcat 8+ use cacheSize property, tomcat 6 & tomcat 7 will print a warning. |
bmuschko
suggested changes
Jan 14, 2018
|
OK please wait a few days. |
|
@xingxiuyi Are you still interested in finishing off this pull request? |
|
@bmuschko I'm sorry, my work was too busy before. I will finish the pull_request as soon as possible. |
|
@xingxiuyi Is this still happening? Otherwise I am going to close this PR for now. |
|
Closing this pull request as new test has been provided. Please let me know if you'd like to continue adding one in which case we can reopen the pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some jar like vaadin, contains java source file and other resources file. Tomcat will log warning for each file.
solve this problem: add
cacheSizeconfig.FIX: #170