Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Elementor - scoping of self variable #479

Merged
merged 1 commit into from
May 27, 2024
+10 −7
Merged

Fix for Elementor - scoping of self variable #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crouton.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
Description: A tabbed based display for showing meeting information.
Author: bmlt-enabled
Author URI: https://bmlt.app
Version: 3.19.0
Version: 3.19.1
*/
/* Disallow direct access to the plugin file */
if (basename($_SERVER['PHP_SELF']) == basename(__FILE__)) {
Expand Down
8 changes: 4 additions & 4 deletions croutonjs/src/js/crouton-core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ function Crouton(config) {
clearInterval(lock_id);
callback();
}
}, 100)
}, 100);
};

self.dayTab = function(day_id) {
Expand Down Expand Up @@ -498,7 +498,7 @@ function Crouton(config) {
callback();
};
self.updateMeetingCount = function(showingNow=null) {
self = this;
var self = this;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe const would be better style than var here

let meetingCount = self.meetingData.length;
if (self.meetingCountCallback) self.meetingCountCallback(meetingCount);
if (self.groupCountCallback) self.groupCountCallback(
Expand Down Expand Up @@ -1007,7 +1007,7 @@ Crouton.prototype.meetingModal = function(meetingId) {
croutonMap.showMap(true);
}
Crouton.prototype.searchMap = function() {
self = this;
var self = this;
if (!self.config.map_search || typeof self.config.map_search !== 'object') {
self.config.map_search = {
width: -50,
Expand Down Expand Up @@ -1652,7 +1652,7 @@ function getUniqueFormatsOfType(array, type){
},[]);
}
Crouton.prototype.renderMeetingCount = function() {
self = this;
var self = this;
self.lock(function() {
self.updateMeetingCount()
});
Expand Down
2 changes: 1 addition & 1 deletion croutonjs/src/js/crouton-localization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ function CroutonLocalization(language) {
"meeting_count": "Wöchentliche Meetings:",
"venue_types": "Treffpunktarten",
"venue_type_choices": {
IN_PERSON: "Präsens-Meetings",
IN_PERSON: "Präsenz-Meetings",
VIRTUAL: "Online-Meetings",
},
"service_body_types": {
Expand Down
5 changes: 4 additions & 1 deletion readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Tags: na, meeting list, meeting finder, maps, recovery, addiction, webservant, b
Requires at least: 4.0
Required PHP: 8.0
Tested up to: 6.4.2
Stable tag: 3.19.0
Stable tag: 3.19.1
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html
crouton implements a Tabbed UI for BMLT.
Expand Down Expand Up @@ -36,6 +36,9 @@ https://demo.bmlt.app/crouton

== Changelog ==

= 3.19.1 =
* Fix compatibility issue with Elementor.

= 3.19.0 =
* Integration with Bmlt2Calendar to provide downloadable ICS files for personal calendars
* Russian Translation
Expand Down
Loading