Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed map as a view in display that listens to the filters. show_map=embed #435

Merged
merged 40 commits into from
Nov 8, 2023

Conversation

otrok7
Copy link
Collaborator

@otrok7 otrok7 commented Oct 1, 2023

No description provided.

@otrok7 otrok7 marked this pull request as draft October 1, 2023 13:38
@otrok7 otrok7 marked this pull request as ready for review November 5, 2023 18:49
@@ -5,7 +5,7 @@
Description: A tabbed based display for showing meeting information.
Author: bmlt-enabled
Author URI: https://bmlt.app
Version: 3.16.3
Version: 3.17.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this just be 3.17.0 instead of 3.17.1, as their was no 3.17.0 release

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What ever happened to PHP6, or Java4? During development, 3.17.0 was the embedded map and OSM integration, 3.17.1 was improvements to Meeting-Details-Page generation and other UI elements. It's just that 3.17.0 never made it to release, because development of 3.17.1 sort of overtook it. It doesn't matter, really, but I would like to keep them a an unreleased version and a release, if only to keep the change list for each manageable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fine I mainly don't like that there is no tag associated with the changelog but I guess 3.17.0 beta3 would cover it? Make sure to bump the readme.txt to 3.17.1 as well if thats what you want to use

crouton.php Show resolved Hide resolved
crouton.php Show resolved Hide resolved
croutonjs/src/js/crouton-map.js Outdated Show resolved Hide resolved
readme.txt Show resolved Hide resolved
readme.txt Outdated Show resolved Hide resolved
@otrok7 otrok7 merged commit c782173 into main Nov 8, 2023
1 check passed
@otrok7 otrok7 deleted the embed-map- branch November 8, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants