Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a degenerate case in topk, added a test for it, and fixed it.
The bug
Suppose you have the following item frequencies:
If the next 6 items in the stream are [c, c, c, c, c, c], the Stream will have a count of 48 for c and 45 for b, but
min
will still point to"c"
when it should be pointing to"b"
.At this point if you add a new item,
"f"
, it will replace"c"
instead of replacing"b"
even though"c"
has a higher count.The fix
Keep a reference to the actual minimum Element at all times using
container/heap
.(This is #3 with cleaner commits, but two years later. Sorry about the delay.)