-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clipping deformer & cosmetic fixes #80
Conversation
jatinkhilnani
commented
Jun 2, 2020
•
edited
Loading
edited
- Clipping deformer (Deformers to implement #1)
- Minor corrections to documentation
It looks like this PR only includes the cosmetic fixes? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor cosmetic things, but this all looks good otherwise. Thanks!
|
Along with changes per review comments, included the ones mentioned in comment above (not for older tests). Modified config to include This does not completely resolve the CI check issues due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked that the requested changes are applied. Please review and merge.
Thanks @jatinkhilnani ! I'll take the dependency issue in a separate thread, but yeah, we're generally overdue for some modernization. |