Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SetBiosFromFile #403

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix SetBiosFromFile #403

merged 1 commit into from
Nov 11, 2024

Conversation

jakeschuurmans
Copy link
Collaborator

Fix example

What does this PR implement/change/remove?

Fix SetBiosFromFile
Fix the SetBiosFromFile example

@jakeschuurmans
Fix SetBiosFromFile
63408f3 
Fix example
joelrebel
joelrebel approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally this interface could have accepted an io.Reader

@jakeschuurmans jakeschuurmans merged commit 31918a0 into main Nov 11, 2024
5 checks passed
@jakeschuurmans jakeschuurmans deleted the FS-1833 branch November 11, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelrebel joelrebel joelrebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakeschuurmans @joelrebel