Asrockrack firmware support #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is replaced by the firmware install step, and subsequently will be
moved into a type FirmwareInstallProperties{} which will replace
FirmwareInstallSteps
- Fix up inventory collection on E3C256D4ID-NL
…BMC is under and update
ofaurax
previously approved these changes
Dec 4, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 44.04% 43.42% -0.63%
==========================================
Files 59 59
Lines 5058 5138 +80
==========================================
+ Hits 2228 2231 +3
- Misses 2608 2690 +82
+ Partials 222 217 -5 ☔ View full report in Codecov by Sentry. |
ofaurax
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
Reworks the Asrockrack provider to to use the newer bmclib client firmware interfaces
along with a few fixes for inventory collection and firmware install status lookup.
tested on
E3C256D4ID-NL,E3C246D4I-NLChecklist
The HW vendor this change applies to (if applicable)
Asrockrack
The HW model number, product name this change applies to (if applicable)