Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supermicro no CSRF #364

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Supermicro no CSRF #364

merged 2 commits into from
Nov 13, 2023

Conversation

joelrebel
Copy link
Member

What does this PR implement/change/remove?

Supermicro X11s running on older firmware don't have CSRF support and this change removes the requirement to have a CSRF token so firmware can be updated on those devices.

Checklist

  • [] Tests added
  • Similar commits squashed

The HW vendor this change applies to (if applicable)

Supermicro X11s running BMC firmware 01.71.11 10/25/2019 and older

The HW model number, product name this change applies to (if applicable)

X11DPH-T

Older X11 BMC firmwares don't include CSRF tokens in requests to the BMC API.
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (d7662f2) 44.83% compared to head (f0ee7ed) 45.03%.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           redfishwrapper-changes     #364      +/-   ##
==========================================================
+ Coverage                   44.83%   45.03%   +0.19%     
==========================================================
  Files                          60       60              
  Lines                        5070     5021      -49     
==========================================================
- Hits                         2273     2261      -12     
+ Misses                       2540     2504      -36     
+ Partials                      257      256       -1     
Files Coverage Δ
providers/supermicro/firmware.go 0.00% <ø> (ø)
providers/supermicro/supermicro.go 45.33% <100.00%> (+0.39%) ⬆️
providers/supermicro/x11_firmware_bmc.go 68.54% <100.00%> (+0.51%) ⬆️
providers/supermicro/floppy.go 0.00% <0.00%> (ø)
providers/supermicro/x11_firmware_bios.go 6.10% <0.00%> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelrebel joelrebel merged commit e37fd77 into redfishwrapper-changes Nov 13, 2023
8 of 9 checks passed
@joelrebel joelrebel deleted the smc-nocsrf branch November 13, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants