-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e3c256d4i support #357
e3c256d4i support #357
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
==========================================
+ Coverage 45.05% 45.08% +0.02%
==========================================
Files 54 54
Lines 4208 4228 +20
==========================================
+ Hits 1896 1906 +10
- Misses 2104 2110 +6
- Partials 208 212 +4
☔ View full report in Codecov by Sentry. |
c1793a3
to
844e950
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this submission, can we also make sure this does not cause a regression on the older e3c246d4i
2465349
to
4b08217
Compare
3d7e900
to
e63714c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes!
By default, update is broken on e3c256d4i. This PR fixes it. Compatibility with e3c246d4i needs to be tested