Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User supplied http client in RPC provider: #355

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

jacobweinstock
Copy link
Member

What does this PR implement/change/remove?

This plumbs through either the default or user-supplied http client to the RPC provider.

Checklist

  • Tests added
  • Similar commits squashed

The HW vendor this change applies to (if applicable)

The HW model number, product name this change applies to (if applicable)

The BMC firmware and/or BIOS versions that this change applies to (if applicable)

What version of tooling - vendor specific or opensource does this change depend on (if applicable)

Description for changelog/release notes

This plumbs through either the default or user supplied
http client to the RPC provider.

Signed-off-by: Jacob Weinstock <[email protected]>
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d2aac70) 44.96% compared to head (8c54ad5) 44.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   44.96%   44.93%   -0.04%     
==========================================
  Files          54       54              
  Lines        4203     4206       +3     
==========================================
  Hits         1890     1890              
- Misses       2105     2108       +3     
  Partials      208      208              
Files Coverage Δ
providers/rpc/rpc.go 77.46% <100.00%> (ø)
client.go 58.47% <0.00%> (-0.76%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit b6af042 into bmc-toolbox:main Oct 3, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants