Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/redfish/bios.go: SetBiosConfiguration(ctx, toSet) #344

Closed
wants to merge 4 commits into from

Conversation

splaspood
Copy link
Collaborator

What does this PR implement/change/remove?

Alongside the existing methods to Read/Get the existing BIOS attributes this change implements Update/Set to change those attributes.

Checklist

  • Tests added
  • Similar commits squashed

Description for changelog/release notes

BIOS config attribute updating

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (e23dfc5) 43.73% compared to head (6495779) 43.19%.

Files Patch % Lines
bmc/bios.go 0.00% 40 Missing ⚠️
internal/redfishwrapper/bios.go 0.00% 17 Missing ⚠️
client.go 0.00% 7 Missing ⚠️
providers/redfish/redfish.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
- Coverage   43.73%   43.19%   -0.54%     
==========================================
  Files          60       60              
  Lines        5316     5382      +66     
==========================================
  Hits         2325     2325              
- Misses       2771     2837      +66     
  Partials      220      220              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splaspood splaspood marked this pull request as draft August 15, 2023 15:10
@splaspood splaspood closed this Apr 11, 2024
@splaspood splaspood deleted the bios-config-set-0 branch April 11, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant