asrockrack: Return unknown when nil progress and version match

bmc-toolbox · Nov 24, 2023 · fd2f0a8 · fd2f0a8
1 parent 834c495
commit fd2f0a8
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/providers/asrockrack/firmware.go b/providers/asrockrack/firmware.go
@@ -184,6 +184,13 @@ func (a *ASRockRack) firmwareUpdateStatus(ctx context.Context, component string,
 
 	switch installStatus {
 	case versionStrMatch:
+		if progress == nil {
+			// TODO: we should pass the force parameter to firmwareUpdateStatus,
+			// so that we can know if we expect a version change or not
+			a.log.V(3).Info("Nil progress + no version change -> unknown")
+			return constants.FirmwareInstallUnknown, nil
+		}
+
 		return constants.FirmwareInstallComplete, nil
 	case versionStrEmpty:
 		return constants.FirmwareInstallUnknown, nil