Skip to content

Commit

Permalink
Remove traces + return on 500
Browse files Browse the repository at this point in the history
  • Loading branch information
ofaurax committed Nov 13, 2023
1 parent e7c94a1 commit 9051b24
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions providers/asrockrack/firmware.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ const (
func (a *ASRockRack) FirmwareInstall(ctx context.Context, component, applyAt string, forceInstall bool, reader io.Reader) (jobID string, err error) {
var size int64

mybytes, err := io.ReadAll(reader)
fmt.Printf("ReadAll reader top firmware install len:%d\n", len(mybytes))

if file, ok := reader.(*os.File); ok {
fmt.Printf("Type file OK\n")
finfo, err := file.Stat()
Expand Down Expand Up @@ -90,9 +87,6 @@ func (a *ASRockRack) firmwareInstallBMC(ctx context.Context, reader io.Reader, f
return errors.Wrap(err, "failed in step 1/4 - set device to flash mode")
}

mybytes, err := io.ReadAll(reader)
fmt.Printf("ReadAll reader after setFlashMode len:%d\n", len(mybytes))

// 2. upload firmware image file
fwEndpoint := "api/maintenance/firmware"
// E3C256D4ID-NL calls a different endpoint for firmware upload
Expand Down Expand Up @@ -178,7 +172,6 @@ func (a *ASRockRack) firmwareUpdateStatus(ctx context.Context, component string,
progress, err := a.flashProgress(ctx, endpoint)
if err != nil {
a.log.V(3).Error(err, "bmc query for install progress returned error: ")
return constants.FirmwareInstallComplete, nil
}

if progress != nil {
Expand Down

0 comments on commit 9051b24

Please sign in to comment.