Nedd to check return value of seek

bmc-toolbox · Oct 26, 2023 · 4abc245 · 4abc245
1 parent 8892008
commit 4abc245
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/providers/asrockrack/firmware.go b/providers/asrockrack/firmware.go
@@ -78,8 +78,10 @@ func (a *ASRockRack) firmwareInstallBMC(ctx context.Context, reader io.Reader, f
 		// Try the special URL for e3c256d4i
 		a.log.V(2).WithValues("step", "2/4").Info("Try alternate URL")
 		// Restart reader from start
-		reader.(*os.File).Seek(0, io.SeekStart)
-		err2 := a.uploadFirmware(ctx, "api/maintenance/firmware/firmware", reader, fileSize)
+		_, err2 := reader.(*os.File).Seek(0, io.SeekStart)
+		if err2 != nil {
+			err2 = a.uploadFirmware(ctx, "api/maintenance/firmware/firmware", reader, fileSize)
+		}
 		if err2 != nil {
 			a.log.V(2).WithValues("step", "2/4").Info("Alternate URL err:" + err2.Error())
 			// if also in err, report first error