Fix session leak in Dell provider:

This was leaving open sessions in non Dell machines. Closed sessions when the Dell Open function returns error after successfully opening. Signed-off-by: Jacob Weinstock <[email protected]>
bmc-toolbox · Oct 16, 2023 · 422edc2 · 422edc2
1 parent b6af042
commit 422edc2
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/providers/dell/idrac.go b/providers/dell/idrac.go
@@ -128,10 +128,16 @@ func (c *Conn) Open(ctx context.Context) (err error) {
 	// is available across various BMC vendors, we verify the device we're connected to is dell.
 	manufacturer, err := c.deviceManufacturer(ctx)
 	if err != nil {
+		if er := c.redfishwrapper.Close(ctx); er != nil {
+			return fmt.Errorf("%v: %w", err, er)
+		}
 		return err
 	}
 
 	if !strings.Contains(strings.ToLower(manufacturer), common.VendorDell) {
+		if er := c.redfishwrapper.Close(ctx); er != nil {
+			return fmt.Errorf("%v: %w", err, er)
+		}
 		return bmclibErrs.ErrIncompatibleProvider
 	}