Skip to content

Commit

Permalink
Small clean ups
Browse files Browse the repository at this point in the history
Signed-off-by: Jacob Weinstock <[email protected]>
  • Loading branch information
jacobweinstock committed Oct 17, 2023
1 parent 7e0fd36 commit 2ec02a2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 0 additions & 2 deletions providers/dell/idrac.go
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,6 @@ var errManufacturerUnknown = errors.New("error identifying device manufacturer")

// deviceManufacturer returns the device manufacturer and model attributes
func (c *Conn) deviceManufacturer(ctx context.Context) (vendor string, err error) {
//errManufacturerUnknown := errors.New("error identifying device manufacturer")

systems, err := c.redfishwrapper.Systems()
if err != nil {
fmt.Println(err.Error())
Expand Down
4 changes: 2 additions & 2 deletions providers/dell/idrac_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"os"
"testing"

bmclibErrs "github.com/bmc-toolbox/bmclib/v2/errors"
berrors "github.com/bmc-toolbox/bmclib/v2/errors"
"github.com/go-logr/logr"
"github.com/stretchr/testify/assert"
)
Expand Down Expand Up @@ -134,7 +134,7 @@ func TestOpenErrors(t *testing.T) {
"/redfish/v1/Systems": endpointFunc("/systems.json"),
"/redfish/v1/Systems/System.Embedded.1": endpointFunc("/systems_embedded_not_dell.1.json"),
},
err: bmclibErrs.ErrIncompatibleProvider,
err: berrors.ErrIncompatibleProvider,
},
"manufacturer failure": {
fns: map[string]func(http.ResponseWriter, *http.Request){
Expand Down

0 comments on commit 2ec02a2

Please sign in to comment.