Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v22.4.0 #1815

Merged
merged 63 commits into from
Dec 28, 2023
Merged

v22.4.0 #1815

merged 63 commits into from
Dec 28, 2023

Conversation

bmaltais
Copy link
Owner

  • 2023/12/28 (v22.4.0)
  • Fixed to work tools/convert_diffusers20_original_sd.py. Thanks to Disty0! PR #1016
  • The issues in multi-GPU training are fixed. Thanks to Isotr0py! PR #989 and #1000
    • --ddp_gradient_as_bucket_view and --ddp_bucket_viewoptions are added to sdxl_train.py. Please specify these options for multi-GPU training.
  • IPEX support is updated. Thanks to Disty0!
  • Fixed the bug that the size of the bucket becomes less than min_bucket_reso. Thanks to Cauldrath! PR #1008
  • --sample_at_first option is added to each training script. This option is useful to generate images at the first step, before training. Thanks to shirayu! PR #907
  • --ss option is added to the sampling prompt in training. You can specify the scheduler for the sampling like --ss euler_a. Thanks to shirayu! PR #906
  • keep_tokens_separator is added to the dataset config. This option is useful to keep (prevent from shuffling) the tokens in the captions. See #975 for details. Thanks to Linaqruf!
    • You can specify the separator with an option like --keep_tokens_separator "|||" or with keep_tokens_separator: "|||" in .toml. The tokens before ||| are not shuffled.
  • Attention processor hook is added. See #961 for details. Thanks to rockerBOO!
  • The optimizer PagedAdamW is added. Thanks to xzuyn! PR #955
  • NaN replacement in SDXL VAE is sped up. Thanks to liubo0902! PR #1009
  • Fixed the path error in finetune/make_captions.py. Thanks to CjangCjengh! PR #986

shirayu and others added 30 commits October 29, 2023 19:46
…training

Accept sampler designation in sampling of training
* delete DDP wrapper

* fix train_db vae and train_network

* fix train_db vae and train_network unwrap

* network grad sync

---------

Co-authored-by: Kohya S <[email protected]>
kohya-ss and others added 28 commits December 13, 2023 21:02
IPEX support for Torch 2.1 and fix dtype erros
If max_size is too large relative to max_reso, it will calculate a height of zero for some buckets.
This causes a crash later when it divides the width by the height.

This change also simplifies some math and consolidates the redundant "size" variable into "width".
Update 3 documents' url to the Chinese version.
Update README_中文教程.md
speed up latents nan replace
Fix convert_diffusers20_original_sd.py and add --variant option for loading
Fix convert_diffusers20_original_sd.py and add metadata & variant options
@bmaltais bmaltais merged commit 89cfc46 into master Dec 28, 2023
0 of 2 checks passed
@FurkanGozukara
Copy link
Contributor

FurkanGozukara commented Dec 28, 2023

Amazing PR. So when doing multi GPU training always include --ddp_gradient_as_bucket_view and --ddp_bucket_view ? both of them?

by the way they do not exists in the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.