Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add widget allowing dynamic selection of optional distros #21

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

MHendricks
Copy link
Member

@MHendricks MHendricks commented Jul 3, 2024

Adds support for adding a footer widget to the AliasLaunchWindow, and defines an interface showing users optional distros and letting them enable them. Supports enabled by default and shows the description of each optional distro.

python_RcIfYY6pLD

This requires hab>=0.41.0.

Checklist

  • I have read the CONTRIBUTING.md document
  • I formatted my changes with black
  • I linted my changes with flake8
  • I have added documentation regarding my changes where necessary
  • Any pre-existing tests continue to pass
  • Additional tests were made covering my changes

Types of Changes

  • Bugfix (change that fixes an issue)
  • New Feature (change that adds functionality)
  • Documentation Update (if none of the other choices apply)

Proposed Changes

This lets Widgets make changes to the hab config based on the new URI but
before the URI is applied to other widgets.
This ensures the uri_widget reflects the updated resolver if a URI was updated.
@MHendricks MHendricks force-pushed the mikeh/optional_distros branch from d6ec13e to 1d3d2d6 Compare July 3, 2024 21:26
@MHendricks MHendricks marked this pull request as draft July 11, 2024 01:10
@MHendricks MHendricks force-pushed the mikeh/optional_distros branch from 1d3d2d6 to 494b366 Compare July 20, 2024 01:34
@MHendricks MHendricks marked this pull request as ready for review July 20, 2024 01:35
@MHendricks MHendricks force-pushed the mikeh/optional_distros branch 2 times, most recently from bc11cc3 to 7b58bb8 Compare July 22, 2024 23:38
This is a gui interface allowing configs to define common optional distros
and allowing a user to enable those distros. This interfaces with the
`--requirement` hab cli argument.
@MHendricks MHendricks force-pushed the mikeh/optional_distros branch from 7b58bb8 to 83ca880 Compare July 22, 2024 23:47
@MHendricks MHendricks merged commit 03b6106 into main Jul 22, 2024
15 checks passed
@MHendricks MHendricks deleted the mikeh/optional_distros branch July 22, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant