Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#54 - mail verification #57

Merged
merged 13 commits into from
Aug 30, 2024
Merged

#54 - mail verification #57

merged 13 commits into from
Aug 30, 2024

Conversation

PrabuckiDominik
Copy link
Collaborator

This should close #54 .

@PrabuckiDominik PrabuckiDominik self-assigned this Aug 29, 2024
@PrabuckiDominik PrabuckiDominik linked an issue Aug 29, 2024 that may be closed by this pull request
Mail verification #54
Closed
kamilpiech97
kamilpiech97 previously approved these changes Aug 30, 2024
View reviewed changes
AleksandraKozubal
AleksandraKozubal requested changes Aug 30, 2024
View reviewed changes
Copy link
Member

@AleksandraKozubal AleksandraKozubal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.After registering user it would be good to display a message that a verification email has been sent.
2.Currently the user can log in without verification.
3.Clicking the "verify email address" from an email button redirects to an error:
image

@PrabuckiDominik PrabuckiDominik merged commit 9986a09 into main Aug 30, 2024
3 checks passed
@PrabuckiDominik PrabuckiDominik deleted the 54-mail-verification branch August 30, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksandraKozubal AleksandraKozubal AleksandraKozubal approved these changes

@kamilpiech97 kamilpiech97 kamilpiech97 approved these changes

Assignees

@PrabuckiDominik PrabuckiDominik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mail verification
3 participants
@PrabuckiDominik @kamilpiech97 @AleksandraKozubal