-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#13 - Basic CRUD for tests #18
Conversation
public static function middleware() | ||
{ | ||
return [ | ||
new Middleware("can:create," . Answer::class . ",question", only: ["store"]), | ||
new Middleware("can:clone,answer,question", only: ["clone"]), | ||
new Middleware("can:update,answer", only: ["update", "markAsCorrect", "markAsInvalid"]), | ||
new Middleware("can:delete,answer", only: ["destroy"]), | ||
]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it needed here?
public static function middleware() | ||
{ | ||
return [ | ||
new Middleware("can:update,quiz", only: ["update"]), | ||
new Middleware("can:delete,quiz", only: ["destroy"]), | ||
]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
public static function middleware() | ||
{ | ||
return [ | ||
new Middleware("can:create," . Question::class . ",quiz", only: ["store"]), | ||
new Middleware("can:clone,question,quiz", only: ["clone"]), | ||
new Middleware("can:update,question", only: ["update"]), | ||
new Middleware("can:delete,question", only: ["destroy"]), | ||
]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
app/Models/Answer.php
Outdated
* | ||
* @property bool $isLocked | ||
* @property bool $isCorrect | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* | |
* @property bool $isLocked | |
* @property bool $isCorrect | |
* | |
* @property bool $isLocked | |
* @property bool $isCorrect |
Should close #13 and close #17.