Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#73 - test documentation #75

Merged
merged 56 commits into from
Aug 9, 2024
Merged

#73 - test documentation #75

merged 56 commits into from
Aug 9, 2024

Conversation

JakubKermes
Copy link
Contributor

Added test to check if every public function from traits is described in documentation.
This should close #73.

krzysztofrewak and others added 16 commits June 28, 2024 08:49
@krzysztofrewak
#17 - documentation draft
aed87a0
@PiotrFedak
Merge branch 'main' into docs
45e710f
@PiotrFedak
Marking where you are in the documentation, added img, started to cre…
d17d2f0 
…ate a documentation
@PiotrFedak @JakubKermes
Added toggle between php and Gherkin, also small fixes
bde6054 
Co-Authored-By: Jakub Kermes <[email protected]>
@JakubKermes
add documentation for general section
1f0ab67
@JakubKermes
add documentation Authentication.php
171fff3
@JakubKermes
add rest of the documentation
400785c
@JakubKermes
listed out included traits
4023347
@PiotrFedak
Added highlighting, fix link error, faq page
eb4fd4e
@PiotrFedak
Merge branch 'main' into docs
0157834
@PiotrFedak
node modules to gitignore
6f32d84
@PiotrFedak
delete node files that wasn't supposed to be on github
9ac796d
@JakubKermes
removed function, can be done using Eloquent.php
394488a
@PiotrFedak
copy to clipboard and fixes
7210f1b
@JakubKermes
add missing documentation elements
9f487ca
@JakubKermes
add test draft
fa246db
@JakubKermes JakubKermes linked an issue Jul 3, 2024 that may be closed by this pull request
Test documentation #73
Closed
@JakubKermes JakubKermes marked this pull request as draft July 3, 2024 11:05
@JakubKermes JakubKermes marked this pull request as ready for review July 5, 2024 07:49
@JakubKermes JakubKermes changed the base branch from main to docs July 5, 2024 08:35
@JakubKermes JakubKermes marked this pull request as draft July 9, 2024 07:58
Base automatically changed from docs to main July 9, 2024 09:49
@JakubKermes
Merge branch 'refs/heads/main' into #73-test-documentation
84c7e64 
# Conflicts:
#	docs/elements/console.html
#	docs/elements/context-classes-vs-traits.html
#	docs/elements/database.html
#	docs/elements/http.html
#	docs/elements/middleware.html
#	docs/elements/overview.html
#	docs/elements/session.html
#	docs/elements/spatie-permission.html
#	docs/elements/translations.html
#	docs/index.html
#	docs/index.js
@JakubKermes
small fixes
a2fdf56
@JakubKermes
csf
cd97cb6
@JakubKermes JakubKermes marked this pull request as ready for review July 9, 2024 10:19
EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I don't see "Code blocks" on the docs menu

image

  1. Sometimes some bad happens with text color.

For example here, the word "Given" is not blue

image

Here are the same codeblock, but one is colorful and the second one is green

image

docs/elements/view.html Outdated Show resolved Hide resolved
krzysztofrewak
krzysztofrewak requested changes Jul 9, 2024
View reviewed changes
tests/DocumentationTest.php Outdated Show resolved Hide resolved
tests/DocumentationTest.php Outdated Show resolved Hide resolved
tests/DocumentationTest.php Outdated Show resolved Hide resolved
tests/DocumentationTest.php Outdated Show resolved Hide resolved
tests/DocumentationTest.php Outdated Show resolved Hide resolved
tests/DocumentationTest.php Outdated Show resolved Hide resolved
krzysztofrewak
krzysztofrewak requested changes Jul 9, 2024
View reviewed changes
tests/DocumentationTest.php Outdated Show resolved Hide resolved
tests/DocumentationTest.php Outdated Show resolved Hide resolved
docs/index.html Show resolved Hide resolved
@krzysztofrewak krzysztofrewak mentioned this pull request Jul 10, 2024
Closed
krzysztofrewak
krzysztofrewak requested changes Jul 23, 2024
View reviewed changes
docs/elements/code-blocks.html Outdated Show resolved Hide resolved
tests/DocumentationTest.php Show resolved Hide resolved
tests/DocumentationTest.php Show resolved Hide resolved
@EwelinaSkrzypacz
Copy link
Member

Can we merge that @JakubKermes?

@JakubKermes JakubKermes merged commit 2386d05 into main Aug 9, 2024
2 checks passed
@JakubKermes JakubKermes deleted the #73-test-documentation branch August 9, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwelinaSkrzypacz EwelinaSkrzypacz EwelinaSkrzypacz approved these changes

@krzysztofrewak krzysztofrewak krzysztofrewak approved these changes

@PiotrFedak PiotrFedak Awaiting requested review from PiotrFedak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test documentation
4 participants
@JakubKermes @EwelinaSkrzypacz @krzysztofrewak @PiotrFedak