Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#33 - Extend http tools #51

Merged
merged 14 commits into from
Jun 24, 2024
Merged

#33 - Extend http tools #51

merged 14 commits into from
Jun 24, 2024

Conversation

PiotrFedak
Copy link
Contributor

@PiotrFedak PiotrFedak commented Jun 12, 2024 •
edited
Loading

Split Http feature into two features

This should close #33

HttpResponse:

  • Added Assertions for Various HTTP Response:
  • JSON assertions
  • Status assertions
  • Redirect assertions
  • Cookie assertions
  • Redirect to a specific URL

HttpRequest:

  • Query Parameters
  • Cookie
  • Check if request contains a bearer token

@JakubKermes
Copy link
Contributor

There's still some magic numbers, Maybe refactor everywhere where possible.

@PiotrFedak PiotrFedak marked this pull request as ready for review June 13, 2024 08:16
@PiotrFedak PiotrFedak changed the title #33-Extend-http-tools #33 - Extend-http-tools Jun 13, 2024
@PiotrFedak PiotrFedak changed the title #33 - Extend-http-tools #33 - Extend http tools Jun 13, 2024
JakubKermes
JakubKermes reviewed Jun 13, 2024
View reviewed changes
src/Features/Traits/HttpResponse.php Show resolved Hide resolved
src/Features/Traits/HttpResponse.php Outdated Show resolved Hide resolved
src/Features/Http.php Show resolved Hide resolved
krzysztofrewak
krzysztofrewak requested changes Jun 13, 2024
View reviewed changes
src/Features/Traits/HttpRequest.php Outdated Show resolved Hide resolved
src/Features/Traits/HttpRequest.php Show resolved Hide resolved
src/Features/Traits/HttpResponse.php Outdated Show resolved Hide resolved
src/Features/Traits/HttpResponse.php Outdated Show resolved Hide resolved
krzysztofrewak
krzysztofrewak requested changes Jun 24, 2024
View reviewed changes
src/Features/Request.php Outdated Show resolved Hide resolved
src/Features/Traits/HttpResponse.php Outdated Show resolved Hide resolved
krzysztofrewak
krzysztofrewak requested changes Jun 24, 2024
View reviewed changes
src/Features/Traits/HttpRequest.php Outdated Show resolved Hide resolved
src/Features/Traits/HttpResponse.php Outdated Show resolved Hide resolved
@PiotrFedak PiotrFedak marked this pull request as draft June 24, 2024 13:15
@PiotrFedak PiotrFedak marked this pull request as ready for review June 24, 2024 13:19
@PiotrFedak PiotrFedak merged commit 1dbad07 into main Jun 24, 2024
4 checks passed
@PiotrFedak PiotrFedak deleted the #33-Extend-http-tools branch June 24, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakubKermes JakubKermes JakubKermes approved these changes

@krzysztofrewak krzysztofrewak krzysztofrewak approved these changes

@EwelinaSkrzypacz EwelinaSkrzypacz Awaiting requested review from EwelinaSkrzypacz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend http tools
4 participants
@PiotrFedak @JakubKermes @krzysztofrewak @EwelinaSkrzypacz