#38 - Extend eloquent tools #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzysztofrewak
requested changes
Jun 11, 2024
JakubKermes
reviewed
Jun 14, 2024
src/Features/Traits/Eloquent.php
Outdated
| { | ||
| $modelClass = $this->recognizeModelClass($model); | ||
| $attributes = $table ? $table->getRowsHash() : []; | ||
|
|
||
| $modelClass::factory()->create($attributes); |
There was a problem hiding this comment.
Maybe we should add creating for models without factory?
krzysztofrewak
requested changes
Jun 24, 2024
src/Features/Traits/Eloquent.php
Outdated
| "The model $model1 does not have a $relation relation method.", | ||
| ); | ||
|
|
||
| LaravelRelations::assertRelation($instance, $relation, 'Illuminate\Database\Eloquent\Relations\HasMany'); |
There was a problem hiding this comment.
Please look at this file: https://github.com/blumilksoftware/blt/blob/main/src/LaravelContracts.php and try to replicate its purpose here.
JakubKermes
reviewed
Jun 25, 2024
krzysztofrewak
approved these changes
Jun 28, 2024
kamilpiech97
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new functions to the eloquent trait.
This should close #38