Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor video feed refactor #7536

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Minor video feed refactor #7536

merged 2 commits into from
Jan 22, 2025

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jan 22, 2025 •
edited
Loading

Just tidying up the code:

  • Avoid extra runtime checks by tightening the types
  • Remove default argument, be explicit in the calling code

Review without whitespace

Test Plan

Can still swipe up and down. Can still start in the middle. Can still navigate away to author and back.

@arcalinea arcalinea temporarily deployed to ref-video-feed - social-app PR #7536 January 22, 2025 01:11 — with Render Destroyed
@gaearon gaearon requested a review from mozzius January 22, 2025 01:12
@github-actions GitHub Actions
Copy link

Old size New size Diff
6.96 MB 6.96 MB 0 B (0.00%)

mozzius
mozzius approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaearon gaearon merged commit d4cf675 into main Jan 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozzius mozzius mozzius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @mozzius @arcalinea