Download images to separate directory on Android #7209
Conversation
|
This is my first time contributing to this repo and I'm pretty rusty on my RN/Expo, so please let me know if there's anything I can fix/improve on! |
ClementTsang
force-pushed
the
android_download_images_to_pictures_directory
branch
from
e5a1192 to
aca3e97
Compare
ClementTsang
changed the title
ClementTsang
force-pushed
the
android_download_images_to_pictures_directory
branch
from
2a89a5e to
24c4c74
Compare
|
Just to set expectations, this part of the code is notably finicky so we need to be careful making changes and testing. At the very least we'd need to test this against multiple real devices and a range of Android versions from 12 to 15. |
|
Makes sense. Unfortunately I don't have many phones in that range, but I've tested this on my S23+ (Android 14) as well, and it works as expected. I can test more devices via emulator as well if that'll help. |
|
Tested on the following android versions via emulator:
|
|
When is this important feature getting merged? |
This commit addresses the issue on Android where all images are stored in DCIM, which people have complained about. Instead, on Android, it now saves to `Pictures/Bluesky`, by using react-native-blob-util (https://github.com/RonRadtke/react-native-blob-util), which is a more updated fork of rn-fetch-blob.
ClementTsang
force-pushed
the
android_download_images_to_pictures_directory
branch
from
24c4c74 to
32d6d5e
Compare
|
Rebased to Might be helpful to also get workflows running to see if there's anything I missed... |
This PR addresses the issue on Android where all images are stored in DCIM, which people have complained about as it interferes with actual pictures for things like Google Photos. Instead, on Android, it now saves to
Pictures/Bluesky, by using react-native-blob-util (https://github.com/RonRadtke/react-native-blob-util), which is a more updated fork of rn-fetch-blob.I've only tested this on an Android emulator (Pixel 8a, Android 13) as of now, can test more if needed.
Closes: #1360