Provide more information on pdsadmin error #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sigafoos
commented
Feb 23, 2024
| @@ -20,7 +20,8 @@ SCRIPT_URL="${PDSADMIN_BASE_URL}/${COMMAND}.sh" | |||
| SCRIPT_FILE="$(mktemp /tmp/pdsadmin.${COMMAND}.XXXXXX)" | |||
|
|
|||
| if ! curl --fail --silent --show-error --location --output "${SCRIPT_FILE}" "${SCRIPT_URL}"; then | |||
| echo "ERROR: ${COMMAND} not found" | |||
| echo "ERROR: command '$0 ${COMMAND}' not found" | |||
There was a problem hiding this comment.
Suggested change
| echo "ERROR: command '$0 ${COMMAND}' not found" | |
| echo "ERROR: command '${COMMAND}' not found" |
might also work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was getting my test PDS set up I was confusing "you provided an invalid command" with "the resource on your PDS was not found". The error message was there, but my changes make it more clear to me. If you disagree feel free to close this!
It will now provide this help message:
(with
pdsadmin.shbeing replaced bypdsadminwhen run on a server, since it uses$0)