Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOBL-1834] Remove the cached email from SharedPreferences #360

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

rahulrvp
Copy link
Collaborator

This change removes the email address stored in the SharedPreference for tracking the change in email address. The identify event fired when the email address is changed is not disabled. The app should explicitly fire the identify event when user info changes.

@rahulrvp rahulrvp self-assigned this Jun 11, 2024
Copy link

@ketanshikharebsft ketanshikharebsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulrvp rahulrvp merged commit c1cfbd4 into dev Jun 12, 2024
1 check passed
@rahulrvp rahulrvp deleted the 1834_remove_cached_email branch June 12, 2024 09:21
rahulrvp added a commit that referenced this pull request Jun 13, 2024
* Renamed encrypted preference file to have the blueshift package name

* Removed the check for email address change to fire identify event

* Fixed the confusion regarding naming

* Fixed the confusion regarding naming of the flag

* Fixed the tests wit additional test case and naming corrections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants