Move the workaround.

bluescarni · Dec 16, 2024 · 1ae19f3 · 1ae19f3
1 parent 961f399
commit 1ae19f3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -8,6 +8,12 @@ jobs:
     resource_class: large
     steps:
     - checkout
+    # NOTE: temporary workaround for asan failures with too
+    # much entropy. See:
+    # https://github.com/google/sanitizers/issues/1614
+    - run:
+        name: Fix mmap_rnd_bits for asan
+        command: sudo sysctl vm.mmap_rnd_bits=28
     - run:
         name: Build and test
         command: bash ./tools/circleci_conda_asan.sh

diff --git a/tools/circleci_conda_asan.sh b/tools/circleci_conda_asan.sh
@@ -9,11 +9,6 @@ set -e
 # Core deps.
 sudo apt-get install wget
 
-# NOTE: temporary workaround for asan failures with too
-# much entropy. See:
-# https://github.com/google/sanitizers/issues/1614
-sudo sysctl vm.mmap_rnd_bits=28
-
 # Install conda+deps.
 wget https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Linux-x86_64.sh -O miniconda.sh
 export deps_dir=$HOME/local