Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back telemetry-frequency setting #1521

Conversation

ArturoManzoli
Copy link
Contributor

@ArturoManzoli ArturoManzoli commented Jan 2, 2025

Added back the telemetry frequency slider.
It used to be on a separate tab, but for vertical space saving, it was moved into a Settings expansible panel:

image

Solves #1515

@ArturoManzoli ArturoManzoli changed the title Views: Telemetry: Add telemetry update frequency slider Add telemetry frequency slider setting Jan 2, 2025
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove also the selectedTab variable as well as other leftovers (if any)?

@ArturoManzoli
Copy link
Contributor Author

Can you remove also the selectedTab variable as well as other leftovers (if any)?

On its way 😃

@ArturoManzoli ArturoManzoli force-pushed the 1515-telemetry-frequency-slider-missing branch from ff0a99f to 75fcd7c Compare January 2, 2025 17:37
@ArturoManzoli ArturoManzoli changed the title Add telemetry frequency slider setting Add telemetry frequency setting Jan 2, 2025
@rafaellehmkuhl rafaellehmkuhl merged commit 24e1882 into bluerobotics:master Jan 2, 2025
11 checks passed
@rafaellehmkuhl rafaellehmkuhl changed the title Add telemetry frequency setting Add back telemetry-frequency setting Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants