Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Skip windows tests (#1573) #1574

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Jul 19, 2023

Description

Windows tests currently cannot be executed as the certificate for the windows audio driver is expired.
Developers need to test locally in the mean time.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

#1573
duncanthrax/scream#202

@Gustl22 Gustl22 requested a review from spydon July 19, 2023 08:34
@Gustl22 Gustl22 changed the title ci: skip windows tests (#1573) ci: Skip windows tests (#1573) Jul 19, 2023
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the solution to this?

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Jul 19, 2023

@spydon
Installing this virtual audio device is the recommended way of Github: actions/runner-images#2528

We need to wait for the maintainer to gain a certificate, explained here: duncanthrax/scream#202
In the mean time we have to wait unfortunately and test locally, where audio can be played from e.g. a real device.

@Gustl22 Gustl22 enabled auto-merge (squash) July 19, 2023 08:57
@Gustl22 Gustl22 merged commit d954b26 into main Jul 19, 2023
@Gustl22 Gustl22 deleted the gustl22/1573-disable-tests-windows branch July 19, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants