Modified code to properly propogate openldap errors, also added a reg… #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex check to keystone user password.
| @@ -106,8 +113,13 @@ def update_user(self, user_id, user): | |||
| # values are already equal. | |||
| user['enabled'] = not user['enabled'] | |||
| old_obj['enabled'] = not old_obj['enabled'] | |||
| try: | |||
| self.user.update(user_id, user, old_obj) | |||
| except ldap.CONSTRAINT_VIOLATION as e: | |||
There was a problem hiding this comment.
What happens when there is no ldap backend?
There was a problem hiding this comment.
The code itself is in the driver for the ldap backend, if there is no ldap backend this code is never called.
|
Why is this not being upstreamed first ? |
|
I had opened a request for a change like this, we were told that keystone should federate with an idp rather than implement this by itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes are made.