Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some warnings and general cleanup #248

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Fix some warnings and general cleanup #248

wants to merge 15 commits into from

Commits on May 4, 2023

  1. Clear objects of non-trivial type

    @voidanix
    voidanix committed May 4, 2023
    Configuration menu
    Copy the full SHA
    4040038 View commit details
    Browse the repository at this point in the history

  2. Fix possible uninitializations

    @voidanix
    voidanix committed May 4, 2023
    Configuration menu
    Copy the full SHA
    7272660 View commit details
    Browse the repository at this point in the history

  3. Convert weapon selection system to std::vector 

    Also introduces a new "inrange" function, useful for future refactorings
to std::vector
    @voidanix
    voidanix committed May 4, 2023
    Configuration menu
    Copy the full SHA
    2ba65bb View commit details
    Browse the repository at this point in the history

  4. Document what the sound enums actually are

    @voidanix
    voidanix committed May 4, 2023
    Configuration menu
    Copy the full SHA
    f07eb85 View commit details
    Browse the repository at this point in the history

  5. Fix unneeded parenthesis

    @voidanix
    voidanix committed May 4, 2023
    Configuration menu
    Copy the full SHA
    3b800a4 View commit details
    Browse the repository at this point in the history

  6. Fix comparison between different signedness

    @voidanix
    voidanix committed May 4, 2023
    Configuration menu
    Copy the full SHA
    c8143e6 View commit details
    Browse the repository at this point in the history

  7. Fix address of array always returning true

    @voidanix
    voidanix committed May 4, 2023
    Configuration menu
    Copy the full SHA
    bb50c90 View commit details
    Browse the repository at this point in the history

  8. Remove set but unused variables

    @voidanix
    voidanix committed May 4, 2023
    Configuration menu
    Copy the full SHA
    af57554 View commit details
    Browse the repository at this point in the history

  9. Fix implicit conversion between float and int

    @voidanix
    voidanix committed May 4, 2023
    Configuration menu
    Copy the full SHA
    dd33dfb View commit details
    Browse the repository at this point in the history

  10. Fix shift with negative value

    @voidanix
    voidanix committed May 4, 2023
    Configuration menu
    Copy the full SHA
    d7b723e View commit details
    Browse the repository at this point in the history

  11. Attempt to fix misleading indentation warning

    @voidanix
    voidanix committed May 4, 2023
    Configuration menu
    Copy the full SHA
    3eb9dac View commit details
    Browse the repository at this point in the history

  12. Fix -Wint-in-bool-context 

    The mattrig macro expands the mw argument at one point into:

if (curmat != MAT_WATER ? S_SPLASH2 : S_SPLASH1 >= 0)

Co-authored-by: Robert Alm Nilsson <[email protected]>
    @voidanix
    voidanix and Robert Alm Nilsson committed May 4, 2023
    Configuration menu
    Copy the full SHA
    64ae458 View commit details
    Browse the repository at this point in the history

  13. tools: Remove custom NULL 

    There should be no reason to overwrite this as the C++ spec already
specifies it. Compilers nowadays also gift us a dedicated warning for this
kind of situation (-Wzero-as-null-pointer-constant).

Remove it and specify <cstddef> to still make NULL accessible.
    @voidanix
    voidanix committed May 4, 2023
    Configuration menu
    Copy the full SHA
    d938486 View commit details
    Browse the repository at this point in the history

  14. engine: Use std::atomic, not volatile for errors 

    This usage of volatile has been deprecated since C++20: use std::atomic
in its place.
    @voidanix
    voidanix committed May 4, 2023
    Configuration menu
    Copy the full SHA
    7cdfbc2 View commit details
    Browse the repository at this point in the history

  15. weapons: Prevent arithmetic between different enum types 

    Deprecated in C++20
    @voidanix
    voidanix committed May 4, 2023
    Configuration menu
    Copy the full SHA
    5b28d72 View commit details
    Browse the repository at this point in the history