-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: snippets #51
Merged
Merged
feat: snippets #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayou-brogrammer
added
type: feature
Brand new functionality, features, pages, workflows, endpoints, etc.
type: discussion
Questions, proposals and info that requires discussion.
labels
Feb 7, 2024
gmpinder
requested changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further discussions still need to be had for how to support this and for which modules:
I added my comment in #41 alongside some concerned questions on Discord, but here's more of a PR review:
|
gmpinder
requested changes
Feb 7, 2024
gmpinder
previously approved these changes
Feb 7, 2024
gmpinder
reviewed
Feb 7, 2024
gmpinder
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: discussion
Questions, proposals and info that requires discussion.
type: feature
Brand new functionality, features, pages, workflows, endpoints, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
This PR adds snippets which is being discussed in #41 .
It will generate snippet lines for ONLY our containerfile module
Preview
Recipe.yml
Generated Container File snippet