Skip to content
This repository has been archived by the owner on Jun 11, 2023. It is now read-only.

Commit

Permalink
⚙ Bump dependency; resolve #2
Browse files Browse the repository at this point in the history
  • Loading branch information
blood72 committed Jun 22, 2021
1 parent 133de38 commit 1a41008
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 11 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ It supports initialize LeagueAPI and DataDragonAPI and adjusted to use Laravel c

- PHP >= 7.3
- Laravel ^7.0 | ^8.0
- dolejska-daniel/riot-api ^4.1.3
- dolejska-daniel/riot-api ^5.0.0

## Installation

Expand Down
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"authors": [
{
"name": "blood72",
"email": "blood72@naver.com"
"email": "blood72@kakao.com"
}
],
"support": {
Expand All @@ -22,7 +22,7 @@
},
"require": {
"php": ">=7.3",
"dolejska-daniel/riot-api": "^4.1.3",
"dolejska-daniel/riot-api": "^5.0.0",
"illuminate/cache": "^7.0|^8.0"
},
"require-dev": {
Expand Down
4 changes: 1 addition & 3 deletions config/riot-api.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,20 @@
return [
'key' => env('RIOT_API_KEY'),

'region' => env('RIOT_API_REGION', \RiotAPI\LeagueAPI\Definitions\Region::NORTH_AMERICA),
'region' => env('RIOT_API_REGION', \RiotAPI\Base\Definitions\Region::NORTH_AMERICA),

'cache' => env('RIOT_API_CACHE', true),

'locale' => env('RIOT_API_LOCALE', 'en_US'),

'league' => [
'cache_namespace' => \RiotAPI\LeagueAPI\Definitions\Cache::LEAGUEAPI_NAMESPACE,
'ddragon_linking' => env('RIOT_API_LEAGUE_LINKING', true),
'settings' => [
//
],
],

'ddragon' => [
'cache_namespace' => \RiotAPI\LeagueAPI\Definitions\Cache::DATADRAGON_NAMESPACE,
'settings' => [
//
],
Expand Down
2 changes: 0 additions & 2 deletions src/RiotAPIServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,9 @@ protected function resolveLeagueAPI()
LeagueAPI::SET_CACHE_PROVIDER => get_class($app['cache.psr6']),
LeagueAPI::SET_CACHE_PROVIDER_PARAMS => [
$app['cache.store'],
$app['config']->get('riot-api.league.cache_namespace'),
],
LeagueAPI::SET_DD_CACHE_PROVIDER_PARAMS => [
$app['cache.store'],
$app['config']->get('riot-api.ddragon.cache_namespace'),
],
], $app['config']->get('riot-api.league.settings')));

Expand Down
4 changes: 2 additions & 2 deletions tests/ServiceProviderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public function it_is_possible_to_defer_a_provider()
/** @var \Illuminate\Support\ServiceProvider $provider */
$provider = $this->getMockBuilder(RiotAPIServiceProvider::class)
->disableOriginalConstructor()
->setMethodsExcept(['isDeferred'])
->onlyMethods([])
->getMock();

$actual = $provider->isDeferred();
Expand All @@ -36,7 +36,7 @@ public function it_can_provide_services(): void
/** @var \Illuminate\Support\ServiceProvider $provider */
$provider = $this->getMockBuilder(RiotAPIServiceProvider::class)
->disableOriginalConstructor()
->setMethodsExcept(['provides'])
->onlyMethods([])
->getMock();

$actual = $provider->provides();
Expand Down
2 changes: 1 addition & 1 deletion tests/TestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
use Blood72\Riot\Facades\LeagueAPI;
use Blood72\Riot\RiotAPIServiceProvider;
use Orchestra\Testbench\TestCase as BaseCase;
use RiotAPI\LeagueAPI\Definitions\Region;
use RiotAPI\Base\Definitions\Region;

abstract class TestCase extends BaseCase
{
Expand Down

0 comments on commit 1a41008

Please sign in to comment.