chore [v1.0]: tidy up processes when session closes #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelneale
commented
Jan 16, 2025
| @@ -128,10 +116,7 @@ export const startGoosed = async (app, dir=null, env={}): Promise<[number, strin | |||
| goosedProcess.kill(); | |||
| }); | |||
|
|
|||
| // Wait for the server to start and fetch the agent version | |||
There was a problem hiding this comment.
we weren't using the version here - as it shifted to the window
michaelneale
commented
Jan 16, 2025
| @@ -19,20 +21,6 @@ export const findAvailablePort = (): Promise<number> => { | |||
| }); | |||
| }; | |||
|
|
|||
| // Function to fetch agent version from the server | |||
There was a problem hiding this comment.
duplicated functionality, and not needed here
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
alexhancock
approved these changes
Jan 16, 2025
Desktop App for this PRThe following build is available for testing: The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this simply closes the goosed process when the window is finished (which it should have).