Basis for named agents #525

zakiali · 2024-12-26T23:58:52Z

This PR adds a framework for named agents and exposes them in the goose-cli and the goose-server. This PR adds:

An Agent trait that agent versions need to implement. The trait itself has default implementations for most methods. Moved original implementation of Agent to BaseAgent (base.rs) and example of a v1 agent (does nothing/raises an error)
Agent factory for registering and instantiating named agents
Updated goose-cli to be able to set named agents on cli and moved away from the Agent implementation in the cli.
Updated goose-server to be able to set/start named agents and provided an endpoint to get current and available versions

github-actions · 2024-12-27T20:18:36Z

Desktop App for this PR

The following build is available for testing:

📱 macOS Desktop App (Universal, signed)

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

github-actions · 2024-12-27T22:44:24Z

Desktop App for this PR

The following build is available for testing:

📱 macOS Desktop App (Universal, signed)

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

github-actions · 2024-12-27T23:42:22Z

Desktop App for this PR

The following build is available for testing:

📱 macOS Desktop App (Universal, signed)

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

github-actions · 2024-12-28T00:55:43Z

Desktop App for this PR

The following build is available for testing:

📱 macOS Desktop App (Universal, signed)

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

michaelneale · 2024-12-28T02:01:06Z

@zakiali can you share any docs on named agents that can share around? as I haven't been keeping up !

baxen

Looks good! The registry makes a lot of sense, and excited to have multiple versions to test against each other. Left a refactor suggestion for the interface

baxen · 2024-12-30T22:30:53Z

crates/goose/src/agents/agent.rs

+    fn get_provider_usage(&self) -> &Mutex<Vec<ProviderUsage>>;
+
+    /// Setup the next inference by budgeting the context window
+    async fn prepare_inference(


nit: i wouldn't leave this as part of the trait i think? although its pretty generally useful agreed, its a private method and i could see an agent taking a different approach

baxen · 2024-12-30T22:31:51Z

crates/goose/src/agents/agent.rs

+    }
+
+    /// Create a stream that yields each message as it's generated
+    async fn reply(&self, messages: &[Message]) -> Result<BoxStream<'_, Result<Message>>> {


nit: i'd probably leave this unimplemented, wdyt? it's nice to reuse here but changes to how this works are the main difference between different agent implementations

+1 to this and the previous comment. these are def the meat of the agents and will have different implementations between versions

baxen · 2024-12-30T22:59:19Z

crates/goose/src/agents/agent.rs

+
+/// Core trait defining the behavior of an Agent
+#[async_trait]
+pub trait Agent: Send + Sync {


(a couple of related comments elsewhere)

I'd suggest a refactor here, where we make this interface only expose the client facing methods:

pub async fn reply // core reply loop pub async fn add_system // connect to or spawn an MCP server via a spec pub async fn remove_system // remove a system by name pub async fn list_systems // get status of each system pub async fn passthrough // pass through a json rpc to a system

and then all the other stuff becomes part of the implementation. But to make that easy/reusable, i'd move all the system management/helper methods onto a new struct, maybe MCPManager or something like that. And then each struct that implements Agent would most likely (but not have to) use that to do the heavy lifting

Refactored, but ended up adding a usage method as well since we use it in cli and was kind of awkward to add it on to the manager (which implements the logic).

salman1993 · 2024-12-31T00:12:50Z

crates/goose/src/agents/v1.rs

+        _pending: &[Message],
+        _target_limit: usize,
+    ) -> AgentResult<Vec<Message>> {
+        todo!();


i don't understand this part. wouldn't reply() fail since this isn't implemented?

yea, this v1 was an example and just wanted something that would error out quickly when testing things out. I'll remove the v1 implementation before merging

salman1993 · 2024-12-31T00:17:41Z

crates/goose/src/agents/base.rs

+}
+
+#[async_trait]
+impl Agent for BaseAgent {


nit: i found this hard to understand, probably cause i was thinking "base" -> "base class" in python. for a while i was thinking Agent depends on BaseAgent lol

since its an implementation of the Agent trait, maybe we use AgentImpl or AgentImplDefault?

What about DefaultAgent instead of BaseAgent? The Impl in the names confuses me a bit, but if that's standard in Rust, happy to do that

i like DefaultAgent

baxen

Looks great!!

zakiali added 6 commits December 26, 2024 14:30

Update agents with core traits to enable versioned agents

5aef01c

Update cli to use new agent versions

c8bdf83

Update goose-server

8f86c42

Comment out v1 agent test

e25d30c

cargo-fmt

7d8f8b3

Implement AgentFactory for registration of named agents

46d14a4

zakiali force-pushed the zaki/named_agents branch from 288cb8e to 46d14a4 Compare December 27, 2024 20:13

zakiali added 2 commits December 27, 2024 12:46

cli list agent versions

10343f4

Add agent versions to session command

a46fed8

zakiali force-pushed the zaki/named_agents branch from 013fc48 to a46fed8 Compare December 27, 2024 22:38

Update server to configure agent versions

9155557

formatting

35893f6

zakiali changed the base branch from v1.0 to v1.0-mcp December 30, 2024 22:05

baxen reviewed Dec 30, 2024

View reviewed changes

salman1993 reviewed Dec 31, 2024

View reviewed changes

Refactor Agent interface

cf1a58c

baxen approved these changes Dec 31, 2024

View reviewed changes

zakiali merged commit 5856a3f into v1.0-mcp Jan 1, 2025

baxen pushed a commit that referenced this pull request Jan 6, 2025

Basis for named agents (#525)

51d9b56

baxen pushed a commit that referenced this pull request Jan 6, 2025

Basis for named agents (#525)

d3cb6b2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Basis for named agents #525

Basis for named agents #525

zakiali commented Dec 26, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024

github-actions bot commented Dec 27, 2024

github-actions bot commented Dec 27, 2024

github-actions bot commented Dec 28, 2024

michaelneale commented Dec 28, 2024

baxen left a comment

baxen Dec 30, 2024

baxen Dec 30, 2024

zakiali Dec 30, 2024

baxen Dec 30, 2024

zakiali Dec 31, 2024

salman1993 Dec 31, 2024

zakiali Dec 31, 2024

salman1993 Dec 31, 2024

salman1993 Dec 31, 2024 •

edited

Loading

zakiali Dec 31, 2024

salman1993 Dec 31, 2024

baxen left a comment

Basis for named agents #525

Basis for named agents #525

Conversation

zakiali commented Dec 26, 2024 • edited Loading

github-actions bot commented Dec 27, 2024

Desktop App for this PR

github-actions bot commented Dec 27, 2024

Desktop App for this PR

github-actions bot commented Dec 27, 2024

Desktop App for this PR

github-actions bot commented Dec 28, 2024

Desktop App for this PR

michaelneale commented Dec 28, 2024

baxen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

salman1993 Dec 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

baxen left a comment

Choose a reason for hiding this comment

zakiali commented Dec 26, 2024 •

edited

Loading

salman1993 Dec 31, 2024 •

edited

Loading